Repository navigation
[3.14] gh-140266: Only pass _PYTHON_HOST_PLATFORM when cross compiling (GH-161530) - #162374
Open
miss-islington wants to merge 1 commit into
Open
miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…pythonGH-161530) configure sets _PYTHON_HOST_PLATFORM only for cross builds, but passed it to the build Python for every --with-build-python build. In a native build it was empty, so sysconfig.get_platform() returned "" and build-details.json ended up with "platform": "". (cherry picked from commit 91c4c6b8270478a6ef89cd0cb36d42c50495350c) Co-authored-by: Itamar Oren <itamarost@gmail.com> Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Kushal Das <mail@kushaldas.in>
miss-islington
requested review from
corona10 and
erlend-aasland
as code owners
November 21, 2026 09:45
This was referenced Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure sets _PYTHON_HOST_PLATFORM only for cross builds, but passed it
to the build Python for every --with-build-python build. In a native
build it was empty, so sysconfig.get_platform() returned "" and
build-details.json ended up with "platform": "".
(cherry picked from commit 91c4c6b)
Co-authored-by: Itamar Oren itamarost@gmail.com
Co-authored-by: Zanie Blue contact@zanie.dev
Co-authored-by: Claude Fable 5.1 noreply@anthropic.com
Co-authored-by: Kushal Das mail@kushaldas.in