Skip to content

gh-140266: Only pass _PYTHON_HOST_PLATFORM when cross compiling - #161530

Merged
kushaldas merged 2 commits into
python:mainfrom
itamaro:gh-140266-host-platform-cross-only
Nov 21, 2026
Merged

kushaldas merged 2 commits into
python:mainfrom
itamaro:gh-140266-host-platform-cross-only

Conversation

@itamaro

@itamaro itamaro commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

configure only sets _PYTHON_HOST_PLATFORM when cross compiling, but PYTHON_FOR_BUILD exported it whenever --with-build-python was given. A native build with a build Python got _PYTHON_HOST_PLATFORM="", which sysconfig.get_platform() returns unchanged, so build-details.json had "platform": "" and the build directory was named build/lib.-3.X.

This passes the variable only when cross compiling.

Tested on macOS with ./configure --with-build-python=... && make build-details.json: platform is macosx-27.2-arm64 and the build directory is named normally.

Written with assistance from Claude Fable 5.1

configure sets _PYTHON_HOST_PLATFORM only for cross builds, but passed it
to the build Python for every --with-build-python build. In a native
build it was empty, so sysconfig.get_platform() returned "" and
build-details.json ended up with "platform": "".

Co-authored-by: Zanie Blue <contact@zanie.dev>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@itamaro
itamaro force-pushed the gh-140266-host-platform-cross-only branch from 4321c38 to c7bf53b Compare November 7, 2026 05:03
@itamaro
itamaro marked this pull request as ready for review November 7, 2026 15:58
@kushaldas kushaldas self-assigned this Nov 15, 2026
superajun-wsj added a commit to superajun-wsj/cpython that referenced this pull request Nov 20, 2026
Merge b09a7e9 while preserving the
prerequisite PR python#161530 and pythongh-162308 fix commits. Resolve the checksharedmods
recipe conflict by using RUNSHARED around MODULE_CHECK_COMMAND: native
checks run the target interpreter and need its runtime library path.
Other upstream RUNSHARED_FOR_BUILD uses remain part of the merged main.
Regenerate configure with Autoconf 2.72.

Validation on the updated source:
- Fresh native host and target builds passed with differing _bisect
  configurations. The original recipe reproduced both import errors;
  the fixed recipe and inherited-platform check had zero import failures.
- A real x86_64-to-AArch64 configure and make all build passed, with all
  enabled target modules passing the file checks.
- test_sysconfig, test_build_details, and test_tools.test_makefile passed:
  68 tests run, 8 skipped.
- Updated workflow YAML, shell syntax, and diff whitespace checks passed.

Co-authored-by: TRAE CLI <traecli@bytedance.com>

@kushaldas kushaldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I cross-compiled AArch64 to verify build works.

@kushaldas
kushaldas enabled auto-merge (squash) November 21, 2026 09:15
@kushaldas
kushaldas merged commit 91c4c6b into python:main Nov 21, 2026
52 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @itamaro for the PR, and @kushaldas for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Nov 21, 2026

Copy link
Copy Markdown

GH-162373 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 21, 2026
@bedevere-app

bedevere-app Bot commented Nov 21, 2026

Copy link
Copy Markdown

GH-162374 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants