Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## perf/stream-html #1242 +/- ##
====================================================
+ Coverage 93.99% 94.02% +0.03%
====================================================
Files 298 300 +2
Lines 31477 31653 +176
Branches 3205 3219 +14
====================================================
+ Hits 29586 29763 +177
+ Misses 1869 1868 -1
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
View all previews: View all previews ↗ |
ovflowd
marked this pull request as ready for review
November 3, 2026 20:39
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 4, 2026 18:24
a21e714 to
529d486
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 6, 2026 13:37
529d486 to
6f084a9
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 6, 2026 19:31
6f084a9 to
62872b1
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 6, 2026 19:43
62872b1 to
78ab04c
Compare
AugustinMauroy
approved these changes
Nov 8, 2026
avivkeller
force-pushed
the
refactor/html-all
branch
from
November 9, 2026 02:26
78ab04c to
0931ca2
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 9, 2026 10:37
0931ca2 to
822cbaf
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 9, 2026 11:03
822cbaf to
a8bfd7f
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 9, 2026 13:25
a8bfd7f to
54e59de
Compare
This was referenced Nov 9, 2026
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 10, 2026 20:53
54e59de to
71861b9
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 11, 2026 00:06
71861b9 to
78217c5
Compare
avivkeller
force-pushed
the
refactor/html-all
branch
from
November 13, 2026 16:45
78217c5 to
4056fed
Compare
avivkeller
force-pushed
the
refactor/html-all
branch
from
November 13, 2026 16:48
4056fed to
16acb7e
Compare
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 17, 2026 14:44
16acb7e to
f64aca9
Compare
avivkeller
force-pushed
the
refactor/html-all
branch
from
November 18, 2026 03:38
f64aca9 to
89a3322
Compare
all.html, every module page's content on one page, is Node.js's, but html built it in, behind generateAllPage, and the streaming work spread its bookkeeping through generate.mjs. It's now a generator of @node-core/doc-kit, html-all, spliced between jsx-ast and html the way section-pages is between metadata and jsx-ast. It passes the pages on, adds all.html's metadata to the manifest, and right after the last module page adds all.html as a page made of theirs, in sidebar order. html only knows that an item with parts, the pages before it that it's made of, is compiled from their content and rendered first, one part at a time instead of building every part's elements before rendering any; generateAllPage goes away. Built with the Node.js preset and the html-all target, the Node.js API docs come out byte-identical, all.html included, at 1 and 4 threads. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
…t lives The code and types already called it a composed page, while the docs, comments and tests said a page made of other pages. They all say composed page now. html-all no longer adds all.html at the end when no manifest came, as jsx-ast always sends one, and each page it lists arrives. html's test of the bundles' timing no longer gives it all.html, whose place html-all's tests check, the composed page's program test only checks what it imports, as html's tests render one, and html's tests build all.html's metadata with createSyntheticHead. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
As jsx-ast and html, html-all always gets an async iterable now, so it drops toBatches and takes only that type. Its test gives the one-thread input with once, and reads the output with Array.fromAsync. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Since the layer below, jsx-ast's manifest lists the pages in the order the site does, so html-all takes all.html's parts in that order instead of sorting them with headingSortFn, which the react package no longer exports. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
ovflowd
force-pushed
the
refactor/html-all
branch
from
November 20, 2026 21:45
89a3322 to
6161190
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves
all.htmlout ofhtmland intohtml-all, a new generator in@node-core/doc-kit: it's Node.js's page, so doc-kit itself shouldn't need to know about it. It's part of the stack that splits #1205.html-allis spliced betweenjsx-astandhtml. It addsall.html's metadata to the manifest and, right after the last module page,all.htmlitself as a composed page of them, in the manifest's order.htmlrenders a composed page (an item withparts) from its parts' compiled content, one part at a time. The worker renderingall.htmlwent from 330-388MB to 176-189MB.generateAllPageis removed, which is a breaking change for@doc-kit/generator-react. Builds that wantall.htmladd-t html-all, as CI's e2e build now does. Node.js's config needs it too (doc: move to redesign node#66713).Validation
Added tests for
html-all(all.htmlright after its last part, and after every page given at once, as with one thread), and forhtmlassembling a composed page from its parts. With-t html-all, the output on 12 of Node.js's API docs is byte-identical tomain's,all.htmlincluded, at 1 and 4 threads.Related Issues
Refs: #1205
Check List
node --run testand all tests passed.node --run format:check&node --run lint.