Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor/html-all #1243 +/- ##
==================================================
Coverage 94.02% 94.02%
==================================================
Files 300 300
Lines 31653 31654 +1
Branches 3219 3219
==================================================
+ Hits 29763 29764 +1
Misses 1868 1868
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
View all previews: View all previews ↗ |
f1082fe to
4d830af
Compare
4d830af to
7e715a5
Compare
7e715a5 to
c97afb1
Compare
c97afb1 to
cf7e6c8
Compare
cf7e6c8 to
fd18bd4
Compare
fd18bd4 to
5624386
Compare
5624386 to
c4b0dc4
Compare
c4b0dc4 to
d6f41cc
Compare
d6f41cc to
c283664
Compare
c283664 to
589914f
Compare
589914f to
120cb75
Compare
120cb75 to
b85c17f
Compare
b85c17f to
90054fe
Compare
Am I right to come to the conclusion this is a local (dev machine) optimization only then? |
No. CI environments usually aren't single threaded either. But the conclusion here is use up to 6 threads (max) instead the default of 4 threads max. So systems with more threads, like Vercel, GHA, local PCs will build faster. Also more threads != needing more cores. |
90054fe to
ecb016b
Compare
With generators streaming into each other, more threads now pay off, so DEFAULT_MAX_THREADS goes from 4 to 6. On the Node.js API docs the site build is ~15% faster at 6 threads than at 4, for ~20% more memory; 8 threads were no faster than 6 and used ~15% more. Machines with fewer CPUs, like CI's 4, are unaffected, and --threads still sets any count. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
ecb016b to
d35dd5c
Compare
Description
This PR makes builds use up to 6 threads by default, instead of 4. It's the last part of the stack that splits #1205. Machines with fewer CPUs, like CI's 4, are unaffected, and
--threadsstill sets any count.main8 threads were no faster than 6, and used ~15% more memory.
Validation
With
-p 1under--max-old-space-size=512, the site build still passed all 11 runs at ~1000MB peak, and legacy all 3 at 877MB.Related Issues
Refs: #1205, and nodejs/nodejs.org#9253, which caches tokens for both themes and makes the site build faster still.
Check List
node --run testand all tests passed.node --run format:check&node --run lint.