Repository navigation
ci: add PHP 8.6 to test matrix, migrate tests to phunit - #170
Conversation
add PHP 8.5 o the test-matrix
add PHP 8.5 o the test-matrix
add PHP 8.5 o the test-matrix
|
As manual review is hard with this much changes, here the info from claude. Context Phpunit: Things to know Context PHPStan: |
dbu
left a comment
There was a problem hiding this comment.
thanks! the changes to src are minimal and all look sane.
which gives me confidence the tests are alright, as they are still green.
the untyped method handling makes me itch to raise minimal php version, but i think for these libraries there is value to keep supporting legacy as long as its no bigger hassle.
based on #168