Repository navigation
feat: add support for PHP 8.5 - #178
Merged
Merged
Conversation
Contributor
Author
|
Failing Code Coverage job is unrelated. |
Contributor
Author
|
PHP 8.6 support can be added by a follow up PR, after phpspec/phpspec 9 is released |
Contributor
|
thanks. yeah i kicked out the coverage in many repos, its not like i looked at the result anyways... i also converted tests to phpunit from phpspec in other repos, as it seems to usually lag behind. (but maybe they got more active again, with the 8.4 or 8.5 versions it was months after the release and still no support) |
Contributor
|
does this need a release? its just changes to ci setup and dev dependencies. |
Contributor
Author
|
no release needed. |
Closed
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #177