You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(table): use correct caret icon in CollapseColumn for expandable rows - #12728
Changes CollapseColumn.tsx to use RhMicronsCaretRightIcon instead of RhMicronsCaretDownIcon, aligning the standard expandable row toggle with the tree-view pattern already used in treeRow.tsx.
Changes
CollapseColumn.tsx: Replaced RhMicronsCaretDownIcon import and usage with RhMicronsCaretRightIcon
Before (current)
Collapsed: ▼ (caret-down at 0°)
Expanded: ▲ (caret-down rotated -180°)
After (this PR)
Collapsed: ► (caret-right at 0°)
Expanded: ▼ (caret-right rotated 90°)
Companion CSS PR: will be opened in patternfly/patternfly
The collapse column now displays a right-facing caret instead of a downward-facing caret. This changes the icon shown in the table while leaving the available table functionality unchanged.
This swaps the expandable-row caret icon from down to right, which matches the tree-view pattern. The toggle handler and aria-expanded behavior are unchanged. The downward expanded appearance relies on a separately tracked CSS update, and the risk of merging is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title says the fix changes the caret icon used by CollapseColumn for expandable rows. The changeset does exactly that: CollapseColumn.tsx now renders RhMicronsCaretRightIcon instead of RhMicronsCa…
Linked Issues check
[#12727] requires replacing RhMicronsCaretDownIcon with RhMicronsCaretRightIcon in packages/react-table/src/components/Table/CollapseColumn.tsx. The whole-PR diff (merge base 5276afd to head 99c4da9…
Out of Scope Changes check
The whole-PR diff changes only CollapseColumn.tsx, with +2/-2 lines: the icon import and the icon usage. Both changes directly implement [#12727]. No unrelated files or changes are present. The CSS ch…
Full details: Title check
Explanation
The title says the fix changes the caret icon used by CollapseColumn for expandable rows. The changeset does exactly that: CollapseColumn.tsx now renders RhMicronsCaretRightIcon instead of RhMicronsCaretDownIcon. The title is specific, concise, and names the primary change. The linked objectives (issue #12727) also describe this same icon swap.
Full details: Linked Issues check
Explanation
[#12727] requires replacing RhMicronsCaretDownIcon with RhMicronsCaretRightIcon in packages/react-table/src/components/Table/CollapseColumn.tsx. The whole-PR diff (merge base 5276afd to head 99c4da9) shows the import changed to rh-microns-caret-right-icon and the rendered icon changed to <RhMicronsCaretRightIcon />, inside the same tableToggleIcon wrapper. This is the only coding requirement in the issue, and it is met. The issue's companion CSS work (patternfly/patternfly#8712) is non-coding for this repository and is out of this PR's scope. The issue does not require new automated tests. The diff does not update any snapshot files; if a snapshot in the Table test suite renders this icon, that snapshot may now fail. This was not verified and does not affect the coding requirement.
Full details: Out of Scope Changes check
Explanation
The whole-PR diff changes only CollapseColumn.tsx, with +2/-2 lines: the icon import and the icon usage. Both changes directly implement [#12727]. No unrelated files or changes are present. The CSS change referenced in the PR description and linked issue is not part of this PR, so it does not add out-of-scope changes.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
CollapseColumn.tsxto useRhMicronsCaretRightIconinstead ofRhMicronsCaretDownIcon, aligning the standard expandable row toggle with the tree-view pattern already used intreeRow.tsx.Changes
CollapseColumn.tsx: ReplacedRhMicronsCaretDownIconimport and usage withRhMicronsCaretRightIconBefore (current)
After (this PR)
Companion CSS PR: will be opened in patternfly/patternfly
Closes #12727
AI-generated. Review for accuracy.
@rh-gvincent requested from Slack
Chai persona:
Konflux HelpSummary by CodeRabbit