Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9343 +/- ##
==========================================
+ Coverage 87.06% 87.07% +0.01%
==========================================
Files 91 91
Lines 6563 6563
Branches 401 401
==========================================
+ Hits 5714 5715 +1
+ Misses 845 844 -1
Partials 4 4 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The ad animation still shifts headings while hidden, ignores reduced-motion preferences, and clips taller creatives before abruptly revealing their full height.
3 open issues
What changed in this PR
This PR changes the Carbon Ads Top Bar to render only when an ad is available, avoiding placeholder-related layout shifts when no ad loads.
Changes:
- Removes the loading placeholder and adds a delayed expand, fade, and slide animation.
- Updates end-to-end tests to check rendering before and after ad availability.
- Documents the new loading and animation behavior.
| File | Description |
|---|---|
docs/carbon-ads.md |
Documents space-free loading and animated entry. |
apps/site/tests/e2e/carbon-ads.spec.ts |
Checks that the Top Bar appears only after an ad loads. |
apps/site/components/CarbonAds/TopBar.tsx |
Removes the loading placeholder. |
apps/site/components/CarbonAds/index.module.css |
Replaces placeholder styles with entry animation keyframes. |
Review effort: Balanced
Contributor
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
ovflowd
reviewed
Nov 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Following #9250 landing, we've noticed CLS on pages using the Top Bar when no ad loads, due to the placeholder while waiting for an ad already taking up space. After discussion in https://openjs-foundation.slack.com/archives/C09EXEEHFKP/p1794936106221269, we've decided it may be better to have the CLS happen only once an ad is ready to display, following the same approach that we use for the announcement banner.
Validation
No CLS on About page when no ad loads. Ad animates in on About page once loaded.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.