Skip to content

[Client] Start stdio servers whose command path has a space - #766

Open
ajibarra wants to merge 1 commit into
modelcontextprotocol:mainfrom
ajibarra:fix/stdio-command-path
Open

ajibarra wants to merge 1 commit into
modelcontextprotocol:mainfrom
ajibarra:fix/stdio-command-path

Conversation

@ajibarra

Copy link
Copy Markdown

StdioTransport built a shell line with escapeshellcmd(), which leaves spaces alone, so a command whose path has one (/Users/me/My Tools/server, C:\Program Files\...) never started. It now hands the command and its arguments to proc_open() as an array, which starts the program without a shell on every platform; a command that relied on the shell to split arguments ('npx -y pkg') has to pass them in args, which the changelog lists as a [BC Break].

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant