Skip to content

docs: fix the vue back button binding and the src/css path in contributing - #4888

Open
thetaPC wants to merge 4 commits into
css-ds-tokensfrom
docs/vue-code-fences
Open

thetaPC wants to merge 4 commits into
css-ds-tokensfrom
docs/vue-code-fences

Conversation

@thetaPC

@thetaPC thetaPC commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Issue URL: N/A

What is the current behavior?

  • Most Vue samples in the docs and the v9 playgrounds are fenced as html. The playground generator already writes vue, so only older samples use html.
  • They get Vue highlighting only because prism-vue.ts points html at the Vue grammar.
  • The Vue back button sample in per-component config binds text with Angular's [text]. Vue treats that as a plain attribute named [text], so the button never gets the text.
  • CONTRIBUTING lists src/styles, which no longer exists.

What is the new behavior?

  • Those samples are fenced as vue. Highlighting looks the same, since both labels already used the Vue grammar.
  • Prettier formats vue blocks with its Vue parser, which removes the indent inside <script>. This matches the samples that were already vue. It also joins some multi-line imports, writes .25 as 0.25 in one progress bar sample, and adds parentheses around one arrow function assignment.
  • The back button sample binds with Vue's :text, in v9 and v8.
  • CONTRIBUTING lists src/css and links to its README.
  • v8's fences and the html alias are unchanged.

Does this introduce a breaking change?

  • Yes
  • No

Other information

How to test

  1. Open the preview's Route usage, select the Vue tab, and compare it with production. The colors match, and the <script> contents are no longer indented.
  2. Open the preview's Textarea Label Placement playground, show the Vue code, and compare it with production. Same result. Opening it in StackBlitz gives a working project.
  3. Open the preview's per-component config and select the Vue tab. The recommended sample uses :text.

Ignoring whitespace, the relabeling commits change only the fence labels: hide whitespace.

Stacked on #4883.

@thetaPC
thetaPC added this pull request to stack #4889 November 20, 2026 19:46
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-docs Ready Ready Preview Nov 20, 2026 10:55pm UTC

Request Review

@thetaPC thetaPC changed the title docs(vue): mark vue samples as vue code blocks docs: fix the vue back button binding and the src/css path in contributing Nov 20, 2026
@thetaPC
thetaPC marked this pull request as ready for review November 20, 2026 23:36
@thetaPC
thetaPC requested a review from a team as a code owner November 20, 2026 23:36

This branch was successfully deployed

1 active deployment
Preview — fdb5c9ae Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant