Repository navigation
Pin CI actions and drop dead packaging config - #21
Merged
Merged
Conversation
Tags like `@v7` can be moved to new code by the action's owner, so CI now pins commit SHAs like the release workflow. Travis CI and nose no longer run, and their leftover config caused setuptools build warnings.
There was a problem hiding this comment.
🟢 Approved
No active review issues block approval of the CI action pinning and obsolete configuration cleanup.
No open issues 🎉
What changed in this PR
This PR hardens CI action references and removes obsolete testing and packaging configuration, aligning CI with the release workflow’s SHA-pinning approach.
Changes:
- Pin checkout and Python setup actions to commit SHAs.
- Delete the unused Travis CI configuration.
- Remove legacy nose testing options and the deprecated license classifier from package metadata.
| File | Description |
|---|---|
setup.py |
Removes obsolete nose options and the deprecated license classifier. |
.travis.yml |
Deletes the legacy Travis CI workflow. |
.github/workflows/ci.yml |
Pins actions to commit SHAs, with version comments for readability. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags like
@v7can be moved to new code by the action's owner, so CI now pins commit SHAs like the release workflow..travis.yml, the nosetest_suite/tests_requireoptions, and the deprecated license classifier were left over from tooling that no longer runs and caused setuptools build warnings.