Skip to content

test: enable remaining tests for p3 - #172

Open
adamrk wants to merge 3 commits into
mainfrom
abk/enable-more-p3-tests
Open

adamrk wants to merge 3 commits into
mainfrom
abk/enable-more-p3-tests

Conversation

@adamrk

@adamrk adamrk commented Nov 20, 2026

Copy link
Copy Markdown
Member

This PR now runs all tests for p3 as well as p2.

  • Enable the weather test on p3
  • Add a Sync bound to the Wait future on p3 since this is needed by the aws-smithy-wasm crate
  • Enable the aws example test on p3

@pchickey pchickey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please remove co-authored-by claude tags per https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md#policy. I added that instruction to my honmedir AGENTS.md, so that it isnt depending on the per-repo one (e.g. wasmtimes).

@adamrk

adamrk commented Nov 21, 2026

Copy link
Copy Markdown
Member Author

oops, my mistake.

@adamrk
adamrk force-pushed the abk/enable-more-p3-tests branch from 1fc5995 to a31a119 Compare November 21, 2026 15:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants