Repository navigation
fixed a whole bunch of errors in overview.md - #348
Merged
Merged
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| This concept determines if an object of type <code>Rcvr</code> supports the completion signature <code>Signature</code>. | ||
| </details> | ||
|
|
||
| <details> | ||
| <summary><code>concept <i>valid-specialization</i><T, Args...></code></summary> | ||
| This concept determines the class template <code>T</code> can be specialized with arguments <code>Args...</code>, i.e., if <code>T<Args...></code> is valid. | ||
| <a id='valid-specialization'></a> | ||
| This concept determines if the class template <code>T</code> can be specialized with arguments <code>Args...</code>, i.e., if <code>T<Args...></code> is valid. | ||
| </details> | ||
|
|
Contributor
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
There was a problem hiding this comment.
🟡 Changes recommended
The change set contains unresolved issues—most notably a critical header modification that breaks in-tree senders relying on a non-templated static consteval get_completion_signatures member, along with additional documentation namespace inconsistencies and an unacknowledged behavioral change despite a doc-only PR title.
3 open issues
What changed in this PR
Updates the execution-model documentation and implementation status formatting, while also modifying get_completion_signatures detection behavior.
Changes:
- Revise and correct
docs/overview.mdcontent, terminology, anchors/links, and examples. - Refresh
docs/implementation-status.mdstatus indicator formatting/presentation. - Adjust
include/beman/execution/detail/get_completion_signatures.hppto remove a fallback customization path.
| File | Description |
|---|---|
| include/beman/execution/detail/get_completion_signatures.hpp | Updates completion-signature discovery logic by removing a legacy fallback for non-templated get_completion_signatures() members. |
| docs/overview.md | Performs a broad documentation cleanup of the execution overview, including terminology, anchors/links, and example code updates. |
| docs/implementation-status.md | Updates the implementation-status documentation formatting and status indicator presentation for improved readability. |
Review effort: Balanced
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
Comment on lines
73
to
77
| ::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>()>) { | ||
| return ::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>(); | ||
| } | ||
| } else if constexpr (requires { | ||
| { | ||
| ::std::remove_cvref_t<Sndr>::get_completion_signatures() | ||
| } -> ::beman::execution::detail::valid_completion_signatures; | ||
| }) { | ||
| if constexpr (::beman::execution::detail::is_constant< | ||
| ::std::remove_cvref_t<Sndr>::get_completion_signatures()>) { | ||
| return ::std::remove_cvref_t<Sndr>::get_completion_signatures(); | ||
| } | ||
| } | ||
| }}; |
| <details> | ||
| <summary><code>stoppable_token<<i>Token</i>></code></summary> | ||
| A <code>stoppable_token<<i>Token</i>></code>, e.g., obtained via <code><a href=‘#get-stop-token’>std::execution::get_stop_token</a>(<i>env</i>)</code> is used to support cancellation of asynchronous operations. Using <code><i>token</i>.stop_requested()</code> an active operation can poll whether it was requested to cancel. An inactive operation waiting for a notification can use an object of a specialization of the template <code><i>Token</i>::callback_type</code> to get notified when cancellation is requested. | ||
| <a id='stoppable_token'></a> | ||
| A <code>stoppable_token<<i>Token</i>></code>, e.g., obtained via <code><a href='#get_stop_token'>std::get_stop_token</a>(<i>env</i>)</code> is used to support cancellation of asynchronous operations. Using <code><i>token</i>.stop_requested()</code> an active operation can poll whether it was requested to cancel. An inactive operation waiting for a notification can use an object of a specialization of the template <code><i>Token</i>::callback_type</code> to get notified when cancellation is requested. |
| @@ -73,15 +73,6 @@ consteval auto get_completion_signatures() -> ::beman::execution::detail::valid_ | |||
| ::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>()>) { | |||
| return ::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>(); | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.