Skip to content

fixed a whole bunch of errors in overview.md - #348

Merged
dietmarkuehl merged 4 commits into
mainfrom
fix-overview
Nov 20, 2026
Merged

dietmarkuehl merged 4 commits into
mainfrom
fix-overview

Conversation

@dietmarkuehl

Copy link
Copy Markdown
Member

No description provided.

@coveralls

coveralls commented Nov 19, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 92.992%. remained the same — fix-overview into main

dietmarkuehl and others added 2 commits November 19, 2026 22:18
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment thread docs/overview.md Outdated
This concept determines if an object of type <code>Rcvr</code> supports the completion signature <code>Signature</code>.
</details>

<details>
<summary><code>concept <i>valid-specialization</i>&lt;T, Args...&gt;</code></summary>
This concept determines the class template <code>T</code> can be specialized with arguments <code>Args...</code>, i.e., if <code>T&lt;Args...&gt;</code> is valid.
<a id='valid-specialization'></a>
This concept determines if the class template <code>T</code> can be specialized with arguments <code>Args...</code>, i.e., if <code>T&lt;Args...&gt;</code> is valid.
</details>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change

@dietmarkuehl
dietmarkuehl marked this pull request as ready for review November 20, 2026 20:56
@dietmarkuehl
dietmarkuehl requested a review from camio as a code owner November 20, 2026 20:56
Copilot AI balanced review requested due to automatic review settings November 20, 2026 20:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change set contains unresolved issues—most notably a critical header modification that breaks in-tree senders relying on a non-templated static consteval get_completion_signatures member, along with additional documentation namespace inconsistencies and an unacknowledged behavioral change despite a doc-only PR title.

3 open issues
What changed in this PR

Updates the execution-model documentation and implementation status formatting, while also modifying get_completion_signatures detection behavior.

Changes:

  • Revise and correct docs/overview.md content, terminology, anchors/links, and examples.
  • Refresh docs/implementation-status.md status indicator formatting/presentation.
  • Adjust include/beman/execution/detail/get_completion_signatures.hpp to remove a fallback customization path.
File Description
include/​beman/​execution/​detail/​get_completion_signatures.hpp Updates completion-signature discovery logic by removing a legacy fallback for non-templated get_completion_signatures() members.
docs/​overview.md Performs a broad documentation cleanup of the execution overview, including terminology, anchors/links, and example code updates.
docs/​implementation-status.md Updates the implementation-status documentation formatting and status indicator presentation for improved readability.

Review effort: Balanced
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

Comment on lines 73 to 77
::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>()>) {
return ::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>();
}
} else if constexpr (requires {
{
::std::remove_cvref_t<Sndr>::get_completion_signatures()
} -> ::beman::execution::detail::valid_completion_signatures;
}) {
if constexpr (::beman::execution::detail::is_constant<
::std::remove_cvref_t<Sndr>::get_completion_signatures()>) {
return ::std::remove_cvref_t<Sndr>::get_completion_signatures();
}
}
}};
Comment thread docs/overview.md
<details>
<summary><code>stoppable_token&lt;<i>Token</i>&gt;</code></summary>
A <code>stoppable_token&lt;<i>Token</i>&gt;</code>, e.g., obtained via <code><a href=‘#get-stop-token’>std::execution::get_stop_token</a>(<i>env</i>)</code> is used to support cancellation of asynchronous operations. Using <code><i>token</i>.stop_requested()</code> an active operation can poll whether it was requested to cancel. An inactive operation waiting for a notification can use an object of a specialization of the template <code><i>Token</i>::callback_type</code> to get notified when cancellation is requested.
<a id='stoppable_token'></a>
A <code>stoppable_token&lt;<i>Token</i>&gt;</code>, e.g., obtained via <code><a href='#get_stop_token'>std::get_stop_token</a>(<i>env</i>)</code> is used to support cancellation of asynchronous operations. Using <code><i>token</i>.stop_requested()</code> an active operation can poll whether it was requested to cancel. An inactive operation waiting for a notification can use an object of a specialization of the template <code><i>Token</i>::callback_type</code> to get notified when cancellation is requested.
@@ -73,15 +73,6 @@ consteval auto get_completion_signatures() -> ::beman::execution::detail::valid_
::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>()>) {
return ::std::remove_cvref_t<Sndr>::template get_completion_signatures<Sndr, E...>();
@dietmarkuehl
dietmarkuehl merged commit 3489ed3 into main Nov 20, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants