Skip to content

fix(aria/combobox): clear pending timeout on destroy - #34167

Open
crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:34166/combobox-destroy
Open

crisbeto wants to merge 1 commit into
angular:mainfrom
crisbeto:34166/combobox-destroy

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes that we were starting a timeout when the combobox is destroyed, but never cleaning it up which can end up throwing an error.

Fixes #34166.

@crisbeto
crisbeto requested a review from ok7sai November 21, 2026 15:10
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 21, 2026
@pullapprove
pullapprove Bot requested a review from andrewseguin November 21, 2026 15:10
element: () => this.element,
expandable: () => true,
popup: computed(() => this._popup()?._pattern),
destroyRef: inject(DestroyRef),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have an established pattern for this sort of case. The other option can be to add a destroy method on the combobox pattern.

Fixes that we were starting a timeout when the combobox is destroyed, but never cleaning it up which can end up throwing an error.

Fixes angular#34166.
@crisbeto
crisbeto force-pushed the 34166/combobox-destroy branch from 6e5011b to 8b0adc1 Compare November 21, 2026 15:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: aria/combobox target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(aria/combobox): focusout timer writes expanded after destroy (NG0953)

1 participant