Skip to content

ci: run semantic pull request and spell check from a single workflow - #148

Draft
marcossevilla wants to merge 1 commit into
mainfrom
ci/unify-pr-checks
Draft

marcossevilla wants to merge 1 commit into
mainfrom
ci/unify-pr-checks

Conversation

@marcossevilla

Copy link
Copy Markdown
Member

Status

READY

Description

Runs the semantic pull request and spell check jobs from a single ci.yaml, apart from the build workflows.

The semantic check was declared in main.yaml and in example.yaml, so pull requests touching example/ were checked twice.

  • ci.yaml has no path filter and listens for edited, so fixing a pull request title re-runs both checks without a new push.
  • A concurrency group cancels the previous run when a newer one starts.
  • Job ids are unchanged (semantic_pull_request, spell-check), so the status check names stay the same.
  • The duplicate semantic-pull-request job from example.yaml is removed.
  • main.yaml is renamed from ci to cli_completion so the two workflows do not share a name (and a concurrency group). The README badge now points at main.yaml instead of the workflow name.
  • The two checks no longer run on pushes to main.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Generated by Claude Code

The semantic pull request check ran from both main.yaml and example.yaml. Both checks now run once from ci.yaml, and re-run when the title is edited.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cvc8ewtN7ZSsbEzx9bNsZK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants