Skip to content

chore: bump the Rust toolchain from 1.88.0 to 1.100.0 - #632

Open
adriencaccia wants to merge 2 commits into
mainfrom
cod-4371-bump-the-runners-rust-toolchain-to-11000
Open

adriencaccia wants to merge 2 commits into
mainfrom
cod-4371-bump-the-runners-rust-toolchain-to-11000

Conversation

@adriencaccia

Copy link
Copy Markdown
Member

Bump the pinned toolchain from 1.88.0 to 1.100.0: current rust-analyzer releases no longer support 1.88.0 and warn on every start.

The first commit fixes the lints clippy 1.100.0 adds, mostly nested ifs collapsed into let chains. The second removes five dependencies cargo now reports as unused (which, perf-event-open-sys, object, static_assertions and the cc build dependency of exec-harness).

Closes COD-4371

@greptile-apps

greptile-apps Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable regression was found.

Summary

Updates the pinned Rust toolchain from 1.88.0 to 1.100.0.

  • The CodSpeed workspace now uses Rust 1.100.0.
  • The runner manifests no longer list five unused dependencies.

Reviews (1) · Last reviewed commit: "chore: remove unused dependencies" · Reviewed by Greptile

adriencaccia and others added 2 commits November 20, 2026 23:32
Current rust-analyzer releases no longer support 1.88.0. Fix the lints
clippy 1.100.0 adds, mostly nested `if`s collapsed into let chains.

Closes COD-4371
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Cargo 1.100.0 warns about them: `which` and `perf-event-open-sys` in the
workspace, `object` and the `cc` build dependency in exec-harness,
`static_assertions` in memtrack.

Refs COD-4371
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@adriencaccia
adriencaccia force-pushed the cod-4371-bump-the-runners-rust-toolchain-to-11000 branch from d618a43 to 2776c75 Compare November 21, 2026 07:32
@codspeed

codspeed Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 21.07%

3 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ 2 benchmarks with a significant change ran in a different software environment

Their base and head results were measured with a different OS or toolchain, such as compiler, runtime or library versions, so the changes might come from this difference rather than from the code. Open an affected benchmark to see what changed.

See affected benchmarks

❌ 2 regressed benchmarks
✅ 51 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime read_spans 63.3 ms 81 ms -21.86%
❌ Walltime read_logs 43.1 ms 54.1 ms -20.28%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cod-4371-bump-the-runners-rust-toolchain-to-11000 (2776c75) with main (da1260d)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant