Skip to content

Adds a RunCommand TiP test - #92

Merged
Joseph Calev (jscalev) merged 3 commits into
mainfrom
dev/jcalev/TestRunCommandScript
Nov 17, 2026
Merged

Joseph Calev (jscalev) merged 3 commits into
mainfrom
dev/jcalev/TestRunCommandScript

Conversation

@jscalev

Copy link
Copy Markdown
Contributor

The primary goal here is to add the first extension "TiP" test, which does the following:

  • Builds the extension locally
  • Creates a VM and adds RunCommand to it
  • Uses CustomScript to replace the RunCommand binaries on the machine with the local ones
  • Performs a suite of tests against RunCommand, including both traditional and immediate RunCommand

In order to accomplish this, we also are fixing two IRC bugs:

  • The handler returned in the status was hard coded to the production extension. Therefore, IRC would not work on test subscriptions. We now take the handler name from the goal state.
  • If the command failed, we returned Success in the executionState for the instance view because the run details were removed from the machine before we sent the status. We now hold onto the details until the status is sent.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread internal/status/immediatestatus.go Resolved
@jscalev
Joseph Calev (jscalev) merged commit e4d9452 into main Nov 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants