From 2a0b923dae44fdb6e3bae5620b39f71d318d1b5e Mon Sep 17 00:00:00 2001 From: Aman Mohamed Ali <69119173+spidervirus@users.noreply.github.com> Date: Thu, 19 Nov 2026 15:47:06 +0400 Subject: [PATCH] fix(maths): prevent 32-bit integer overflow in PythagoreanTriple --- .../java/com/thealgorithms/maths/PythagoreanTriple.java | 6 +++--- .../java/com/thealgorithms/maths/PythagoreanTripleTest.java | 6 ++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/thealgorithms/maths/PythagoreanTriple.java b/src/main/java/com/thealgorithms/maths/PythagoreanTriple.java index 2780b113d904..8e6cd343d078 100644 --- a/src/main/java/com/thealgorithms/maths/PythagoreanTriple.java +++ b/src/main/java/com/thealgorithms/maths/PythagoreanTriple.java @@ -34,9 +34,9 @@ public static boolean isPythagTriple(int a, int b, int c) { int[] sides = {a, b, c}; java.util.Arrays.sort(sides); - int x = sides[0]; - int y = sides[1]; - int hypotenuse = sides[2]; + long x = sides[0]; + long y = sides[1]; + long hypotenuse = sides[2]; return x * x + y * y == hypotenuse * hypotenuse; } diff --git a/src/test/java/com/thealgorithms/maths/PythagoreanTripleTest.java b/src/test/java/com/thealgorithms/maths/PythagoreanTripleTest.java index 75219dc47b47..6ac4301aceeb 100644 --- a/src/test/java/com/thealgorithms/maths/PythagoreanTripleTest.java +++ b/src/test/java/com/thealgorithms/maths/PythagoreanTripleTest.java @@ -10,8 +10,10 @@ public class PythagoreanTripleTest { @ParameterizedTest - @CsvSource({"3, 4, 5, true", "6, 8, 10, true", "9, 12, 15, true", "12, 16, 20, true", "15, 20, 25, true", "18, 24, 30, true", "5, 20, 30, false", "6, 8, 100, false", "-2, -2, 2, false", "0, 0, 0, false", "5, 5, 5, false"}) - void testIsPythagoreanTriple(int a, int b, int c, boolean expected) { + @CsvSource({"3, 4, 5, true", "6, 8, 10, true", "9, 12, 15, true", "12, 16, 20, true", "15, 20, 25, true", "18, 24, 30, true", "30000, 40000, 50000, true", "60000, 80000, 100000, true", "100000, 240000, 260000, true", "30000, 40000, 50001, false", "65536, 65536, 65536, false", "5, 20, 30, false", + "6, 8, 100, false", "-2, -2, 2, false", "0, 0, 0, false", "5, 5, 5, false"}) + void + testIsPythagoreanTriple(int a, int b, int c, boolean expected) { assertEquals(expected, PythagoreanTriple.isPythagTriple(a, b, c)); }